v0.11 Beta 6 vs Beta5: sum of all changes #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoedberg
suggested changes
Apr 11, 2024
Cargo.toml
Outdated
| @@ -94,3 +94,18 @@ serde = ["serde_crate", "serde_with", "serde_yaml", "bp-std/serde", "bp-wallet/s | |||
|
|
|||
| [package.metadata.docs.rs] | |||
| features = ["all"] | |||
|
|
|||
| [patch.crates-io] | |||
| strict_types = { git = "https://github.com/strict-types/strict-types", branch = "master" } | |||
There was a problem hiding this comment.
As reported here RGB-WG/rgb-std#180 (review) rgb-std is not compiling with these patches. If you run cargo update on this repo you'll see the same error that I reported. It seems that in the Cargo.lock file of this repo strict_types was set to master#2350162c, a commit that is not directly referenced by any branch and that is no longer in master history. Since I've seen that commit is part of 2 branches (develop and reconstruct) I've tried both and I've found out that I can compile rgb-lib using the reconstruct branch. So either we merge that commit on master or we change the patched branch here.
There was a problem hiding this comment.
Fixed to reconstruct. Pushed
Update to refactored standard library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.